New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with more AMD compliant wrapper #225

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@jason0x43

jason0x43 commented Dec 20, 2013

Rebuild chai.js using an updated component that fixes an AMD wrapper
bug. There's a PR for the fix to component.

Build with more AMD compliant wrapper
Rebuild chai.js using an updated component that fixes an AMD wrapper
bug.
@coveralls

This comment has been minimized.

coveralls commented Dec 20, 2013

Coverage Status

Coverage remained the same when pulling b09f754 on jason0x43:master into 0e560c6 on chaijs:master.

@vesln

This comment has been minimized.

Member

vesln commented Dec 20, 2013

Thank you for opening the issue!

Could you please share the component fork with us, and also could you please link the PR so we can keep track of it? We are always more than happy to improve the library in order to be more accessible for everyone. Thanks!

@jason0x43

This comment has been minimized.

jason0x43 commented Dec 20, 2013

Sure, the PR is componentjs/component#459. The fork is at jason0x43/component.

@jason0x43

This comment has been minimized.

jason0x43 commented Jan 14, 2014

The referenced PR has been merged.

@csnover

This comment has been minimized.

Contributor

csnover commented Jan 22, 2014

Upstream has fixed this issue, so you just need to update to component 0.19.4+ and build and release. Thanks!

@SlexAxton

This comment has been minimized.

SlexAxton commented Jan 22, 2014

+1 on getting this in!

@logicalparadox

This comment has been minimized.

Member

logicalparadox commented Jan 29, 2014

1.9.0 has been release with this included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment