Build with more AMD compliant wrapper #225

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@jason0x43

Rebuild chai.js using an updated component that fixes an AMD wrapper
bug. There's a PR for the fix to component.

@jason0x43 jason0x43 Build with more AMD compliant wrapper
Rebuild chai.js using an updated component that fixes an AMD wrapper
bug.
b09f754
@coveralls

Coverage Status

Coverage remained the same when pulling b09f754 on jason0x43:master into 0e560c6 on chaijs:master.

@vesln
Member
vesln commented Dec 20, 2013

Thank you for opening the issue!

Could you please share the component fork with us, and also could you please link the PR so we can keep track of it? We are always more than happy to improve the library in order to be more accessible for everyone. Thanks!

@jason0x43

Sure, the PR is componentjs/component#459. The fork is at jason0x43/component.

@jason0x43 jason0x43 referenced this pull request in componentjs/component Jan 14, 2014
Merged

Update wrapper to prevent unintended circular dependencies #459

@jason0x43

The referenced PR has been merged.

@csnover
Contributor
csnover commented Jan 22, 2014

Upstream has fixed this issue, so you just need to update to component 0.19.4+ and build and release. Thanks!

@SlexAxton

+1 on getting this in!

@logicalparadox
Member

1.9.0 has been release with this included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment