Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has to language chains #226

Merged
merged 1 commit into from Jan 25, 2014
Merged

Add has to language chains #226

merged 1 commit into from Jan 25, 2014

Conversation

@duncanbeevers
Copy link
Contributor

@duncanbeevers duncanbeevers commented Dec 27, 2013

Add has to the language chains.

This is to address the awkward phrasing that arises from chaining assertions off of properties.

expect(obj)
  .to.have.property('collection')
  .that.has.members([1, 2, 3])
@coveralls
Copy link

@coveralls coveralls commented Dec 27, 2013

Coverage Status

Coverage remained the same when pulling 4ea26a7 on duncanbeevers:add_has into 564af34 on chaijs:master.

@vesln
Copy link
Member

@vesln vesln commented Dec 27, 2013

Fine by me. @logicalparadox ?

@logicalparadox
Copy link
Member

@logicalparadox logicalparadox commented Jan 23, 2014

👍

vesln added a commit that referenced this pull request Jan 25, 2014
Add `has` to language chains
@vesln vesln merged commit 3835bed into chaijs:master Jan 25, 2014
1 check failed
1 check failed
@logicalparadox
default The Travis CI build could not complete due to an error
Details
@vesln
Copy link
Member

@vesln vesln commented Jan 25, 2014

Thanks!

@duncanbeevers duncanbeevers deleted the duncanbeevers:add_has branch Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants