Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error instantiation if possible on assert.throws #232

Merged
merged 1 commit into from Jan 29, 2014

Conversation

@lorenzogrv
Copy link
Contributor

@lorenzogrv lorenzogrv commented Jan 15, 2014

Given an error constructor as function, try to get the error name from its prototype or itself before relying on the old behaviour.

Closes #220

Replaces the old pull to avoid useless commits.

Given an error constructor as function, try to get the error name from
its prototype or itself before relying on the old behaviour.

Closes #220

Replaces [the old pull](#221) to avoid
useless commits.
@coveralls
Copy link

@coveralls coveralls commented Jan 15, 2014

Coverage Status

Coverage remained the same when pulling 3741f05 on laconbass:assert-throws into 1d0ce13 on chaijs:master.

@qraynaud
Copy link

@qraynaud qraynaud commented Jan 16, 2014

+1

@vesln
Copy link
Member

@vesln vesln commented Jan 27, 2014

Fine by me. @logicalparadox

@logicalparadox
Copy link
Member

@logicalparadox logicalparadox commented Jan 27, 2014

👍

logicalparadox added a commit that referenced this pull request Jan 29, 2014
Avoid error instantiation if possible on assert.throws
@logicalparadox logicalparadox merged commit be23285 into chaijs:master Jan 29, 2014
1 check passed
1 check passed
@logicalparadox
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants