New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error instantiation if possible on assert.throws #232

Merged
merged 1 commit into from Jan 29, 2014

Conversation

Projects
None yet
5 participants
@laconbass
Contributor

laconbass commented Jan 15, 2014

Given an error constructor as function, try to get the error name from its prototype or itself before relying on the old behaviour.

Closes #220

Replaces the old pull to avoid useless commits.

Avoid error instantiation if possible on assert.throws
Given an error constructor as function, try to get the error name from
its prototype or itself before relying on the old behaviour.

Closes #220

Replaces [the old pull](#221) to avoid
useless commits.
@coveralls

This comment has been minimized.

coveralls commented Jan 15, 2014

Coverage Status

Coverage remained the same when pulling 3741f05 on laconbass:assert-throws into 1d0ce13 on chaijs:master.

@qraynaud

This comment has been minimized.

qraynaud commented Jan 16, 2014

+1

@vesln

This comment has been minimized.

Member

vesln commented Jan 27, 2014

Fine by me. @logicalparadox

@logicalparadox

This comment has been minimized.

Member

logicalparadox commented Jan 27, 2014

👍

logicalparadox added a commit that referenced this pull request Jan 29, 2014

Merge pull request #232 from laconbass/assert-throws
Avoid error instantiation if possible on assert.throws

@logicalparadox logicalparadox merged commit be23285 into chaijs:master Jan 29, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment