Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssfi as it should be #233

Merged
merged 1 commit into from Feb 25, 2014
Merged

ssfi as it should be #233

merged 1 commit into from Feb 25, 2014

Conversation

@refack
Copy link

@refack refack commented Jan 18, 2014

No description provided.

@logicalparadox
Copy link
Member

@logicalparadox logicalparadox commented Jan 29, 2014

This cannot automatically be merged. Can you rebase with upstream and reopen this PR?

Also, I see the following issues with your code.

  • Please do not include the browser build @ chai.js in your PR.
  • You made changes to the should interface loader. I don't see how this impacts ssfi and no explanation is given as to why it is changed.
Refael Ackermann
@refack
Copy link
Author

@refack refack commented Jan 30, 2014

Rebased, cleaned & commented.

logicalparadox added a commit that referenced this pull request Feb 25, 2014
ssfi as it should be
@logicalparadox logicalparadox merged commit 07b34c7 into chaijs:master Feb 25, 2014
1 check passed
1 check passed
@logicalparadox
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants