ssfi as it should be #233

Merged
merged 1 commit into from Feb 25, 2014

Projects

None yet

2 participants

@refack
Contributor
refack commented Jan 18, 2014

No description provided.

@logicalparadox
Member

This cannot automatically be merged. Can you rebase with upstream and reopen this PR?

Also, I see the following issues with your code.

  • Please do not include the browser build @ chai.js in your PR.
  • You made changes to the should interface loader. I don't see how this impacts ssfi and no explanation is given as to why it is changed.
@refack
Contributor
refack commented Jan 30, 2014

Rebased, cleaned & commented.

@logicalparadox logicalparadox merged commit 07b34c7 into chaijs:master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment