fixing #239 (without changing chai.js) #244

Merged
merged 5 commits into from Feb 25, 2014

Projects

None yet

4 participants

@leider
Contributor
leider commented Feb 9, 2014
  • hope this is better
@logicalparadox
Member

Much better! Unfortunately, not quite ready yet. I think you will have an issue if no match is found. The best way is to add assertions that fail using err(function() { .... For each assertion you add in test/expect.js you should also have an assertion that fails wrapped with that pattern.

PS: No need to open a new PR this time, you can just append to this one.

@leider
Contributor
leider commented Feb 9, 2014

done. :) Thx for the eagle eyes

@leider
Contributor
leider commented Feb 9, 2014

done again

@leider
Contributor
leider commented Feb 23, 2014

Hi, did you forget about this one? :)

@logicalparadox logicalparadox merged commit 4e25ff0 into chaijs:master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
@adambiggs

Any timeline on merging this? #239 is the only thing preventing me from upgrading :(

@lo1tuma
Contributor
lo1tuma commented Mar 14, 2014

@adambiggs it is already merged. I don’t know why #239 is still open and why there was no patched version released.

@leider leider deleted the unknown repository branch Mar 14, 2014
@adambiggs

@lo1tuma oops, I meant to ask about publishing this to NPM... 😕

@lo1tuma
Contributor
lo1tuma commented Mar 19, 2014

@logicalparadox can you release a patched version on npm?

@logicalparadox
Member

Released in 1.9.1. View release notes.

@lo1tuma
Contributor
lo1tuma commented Mar 19, 2014

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment