New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing #239 (without changing chai.js) #244

Merged
merged 5 commits into from Feb 25, 2014

Conversation

Projects
None yet
4 participants
@leider
Contributor

leider commented Feb 9, 2014

  • hope this is better
@logicalparadox

This comment has been minimized.

Member

logicalparadox commented Feb 9, 2014

Much better! Unfortunately, not quite ready yet. I think you will have an issue if no match is found. The best way is to add assertions that fail using err(function() { .... For each assertion you add in test/expect.js you should also have an assertion that fails wrapped with that pattern.

PS: No need to open a new PR this time, you can just append to this one.

@leider

This comment has been minimized.

Contributor

leider commented Feb 9, 2014

done. :) Thx for the eagle eyes

@leider

This comment has been minimized.

Contributor

leider commented Feb 9, 2014

done again

@leider

This comment has been minimized.

Contributor

leider commented Feb 23, 2014

Hi, did you forget about this one? :)

logicalparadox added a commit that referenced this pull request Feb 25, 2014

Merge pull request #244 from leider/fix_for_contains
fixing #239 (without changing chai.js)

@logicalparadox logicalparadox merged commit 4e25ff0 into chaijs:master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
@adambiggs

This comment has been minimized.

adambiggs commented Mar 11, 2014

Any timeline on merging this? #239 is the only thing preventing me from upgrading :(

@lo1tuma

This comment has been minimized.

Contributor

lo1tuma commented Mar 14, 2014

@adambiggs it is already merged. I don’t know why #239 is still open and why there was no patched version released.

@leider leider deleted the leider:fix_for_contains branch Mar 14, 2014

@adambiggs

This comment has been minimized.

adambiggs commented Mar 14, 2014

@lo1tuma oops, I meant to ask about publishing this to NPM... 😕

@lo1tuma

This comment has been minimized.

Contributor

lo1tuma commented Mar 19, 2014

@logicalparadox can you release a patched version on npm?

@logicalparadox

This comment has been minimized.

Member

logicalparadox commented Mar 19, 2014

Released in 1.9.1. View release notes.

@lo1tuma

This comment has been minimized.

Contributor

lo1tuma commented Mar 19, 2014

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment