Revert "Allows writing lint-friendly tests" #306

Merged
merged 1 commit into from Nov 13, 2014

Projects

None yet

8 participants

@logicalparadox
Member

👍

@keithamus
Member

😦

@keithamus keithamus merged commit b71b930 into master Nov 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@keithamus keithamus deleted the revert-297-noopchainfunc branch Nov 13, 2014
@keithamus
Member

Perhaps a 1.10.1/1.11.0 release?

@joshperry
Contributor

Just wonder if you guys are going to revert this or just leave it until people start to use the new syntax in their code... The chaijs website was also updated to document this new syntax. If we wait too long, reverting may end up being a backcompat issue.

@keithamus
Member

@joshperry indeed. master has been reverted we just need to cut a new release - which is dependant on #337

@johanneswuerbach

I think this change should be published asap (and marked as breaking) as it is advertised for ~ 2 months on your homepage and we (and I think others) already converted our projects to the new syntax.

@keithamus
Member

Yes, you're very right @johanneswuerbach. I'm going to work on getting a release out as soon as I can.

@koulmomo koulmomo added a commit to yahoo/fluxible-action-utils that referenced this pull request Feb 26, 2015
@koulmomo koulmomo ⬆️ bump chai devdep to ^2.0
modify unit tests due to breaking changes from chai 1.10 -> 2.0
chaijs/chai#308
chaijs/chai#306
90e5ec1
@paul-barry-kenzan

Out of curiosity, why was this reverted? Doesn't this reopen #41?

Yeah. Why reverted? I have the same curiosity.

Contributor

@paul-barry-kenzan @walterpinson The best place to read about the issues with the previous attempt at allowing both property and method assertions is: #302, particularly #302 (comment).
#726 contains ongoing discussion related to this issue. Please use that thread for any further discussion.

@sankethkatta

@paul-barry-kenzan I was wondering the same thing. There seems to be some more context here: #371 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment