Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #305 fixed, added assert.isAbove and assert.isBelow #311

Merged
merged 1 commit into from Dec 2, 2014

Conversation

@christophertrml
Copy link

@christophertrml christophertrml commented Nov 29, 2014

I believe this fixes #305 , and adds the isAbove and isBelow functions on assert. All the tests ran fine for me on my machine, let me know if I messed anything (like public api comments) up or if something doesn't look right.

Thanks!

@keithamus
Copy link
Member

@keithamus keithamus commented Nov 29, 2014

Looks pretty great to me - with tests too ❤️! I'll wait for @logicalparadox's approval before merging though.

@keithamus
Copy link
Member

@keithamus keithamus commented Dec 2, 2014

@vesln or @logicalparadox, you happy to see this merged in?

@logicalparadox
Copy link
Member

@logicalparadox logicalparadox commented Dec 2, 2014

👍

keithamus added a commit that referenced this pull request Dec 2, 2014
Issue #305 fixed, added assert.isAbove and assert.isBelow
@keithamus keithamus merged commit 49e003c into chaijs:master Dec 2, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@keithamus keithamus mentioned this pull request Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants