New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #291, adds assert.sameDeepMembers #312

Merged
merged 2 commits into from Dec 3, 2014

Conversation

Projects
None yet
3 participants
@christophertrml
Contributor

christophertrml commented Nov 29, 2014

This should fix #291 and adds the sameDeepMembers function that expect and should already have. If there are any issues please let me know.

Thanks!

@@ -1017,6 +1017,25 @@ module.exports = function (chai, util) {
}

/**
* ### .sameDeepMembers(set1, set2, [message])
*
* Asserts that `set1` and `set2` have deeply the same members.

This comment has been minimized.

@keithamus

keithamus Nov 30, 2014

Member

The wording ("have deeply the same members") is a bit funny here. May I suggest "have the same deep members", or "have the same members - using a deep equality check".

@christophertrml

This comment has been minimized.

Contributor

christophertrml commented Nov 30, 2014

Pushed the comment change, I went with "have the same members - using a deep equality check" since it makes it very explicit.

@keithamus

This comment has been minimized.

Member

keithamus commented Nov 30, 2014

Looks great to me! Thanks for your efforts @cjqed. I'll wait for @logicalparadox to give the 👍 and merge then 😄.

@christophertrml

This comment has been minimized.

Contributor

christophertrml commented Dec 1, 2014

Sounds good @keithamus . I'm probably going to tackle a few more issues that are low hanging fruits and maybe even some tougher ones, I'm just in that kind of mood (and honestly Chai has a very nice codebase!)

@keithamus

This comment has been minimized.

Member

keithamus commented Dec 2, 2014

@vesln or @logicalparadox, you happy to see this merged in? If so I'll hit the big green button.

@logicalparadox

This comment has been minimized.

Member

logicalparadox commented Dec 2, 2014

👍

@keithamus

This comment has been minimized.

Member

keithamus commented Dec 2, 2014

Oof, sorry @cjqed - one of the PRs I just merged conflicts with this one. If you could rebase this branch then I can merge it in. Should be an easy fix - some new tests were added and its just conflicting with your diff - make sure to keep both sets of tests.

Thanks for your patience @cjqed :)

@christophertrml christophertrml force-pushed the christophertrml:291-assert-same-deep-members branch from 1170dd2 to 0d814eb Dec 3, 2014

@christophertrml

This comment has been minimized.

Contributor

christophertrml commented Dec 3, 2014

This should be ready to merge, I'll work on #313 and try to make it so that it can be automerged as well.

@keithamus

This comment has been minimized.

Member

keithamus commented Dec 3, 2014

⭐️

keithamus added a commit that referenced this pull request Dec 3, 2014

Merge pull request #312 from cjqed/291-assert-same-deep-members
Fixes issue #291, adds assert.sameDeepMembers

@keithamus keithamus merged commit f06278f into chaijs:master Dec 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@keithamus keithamus referenced this pull request Feb 12, 2015

Closed

Get a proper changelog #366

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency chai to v4 #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment