New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the util package through the chai object #335

Merged
merged 1 commit into from Jan 2, 2015

Conversation

Projects
None yet
2 participants
@DingoEatingFuzz
Contributor

DingoEatingFuzz commented Dec 30, 2014

The util object has a lot of helpful functions in it that would be nice to use outside the context of assertions.

For instance, if you want to check deep equality without breaking when false.

if (chai.util.eql(obj1, obj2)) {
  // do more things
} else {
  // do other things instead of having a failing assertion
}
Expose chai util through the chai object
The chai util object has a lot of useful functions that can be used
outside of the context of assertions.
@keithamus

This comment has been minimized.

Member

keithamus commented Dec 31, 2014

Hi @DingoEatingFuzz, thanks for the pull request! Seems like a fairly straightforward addition, and I don't have much problem with that.

Having said that I can't merge it just yet, because of commit b4614da. Can you please remove this commit - as we'll generate a new build JS file when we publish a new version.

@DingoEatingFuzz

This comment has been minimized.

Contributor

DingoEatingFuzz commented Dec 31, 2014

Yep, I can remove that. I wasn't sure what the deal with new builds was.

@DingoEatingFuzz DingoEatingFuzz force-pushed the DingoEatingFuzz:expose-util branch from b4614da to ebcfd87 Dec 31, 2014

@keithamus

This comment has been minimized.

Member

keithamus commented Dec 31, 2014

Sorry about that @DingoEatingFuzz; I'll clear this up in the contrib guidelines soon (see #336)

@DingoEatingFuzz

This comment has been minimized.

Contributor

DingoEatingFuzz commented Dec 31, 2014

No worries. The commit is gone now 👍

keithamus added a commit that referenced this pull request Jan 2, 2015

Merge pull request #335 from DingoEatingFuzz/expose-util
Expose the util package through the chai object

@keithamus keithamus merged commit 7e3da21 into chaijs:master Jan 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@keithamus

This comment has been minimized.

Member

keithamus commented Jan 2, 2015

👍

@keithamus keithamus referenced this pull request Feb 12, 2015

Closed

Get a proper changelog #366

@ellenmobify ellenmobify referenced this pull request May 22, 2015

Open

Update Chai to 2.x #3

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency chai to v4 #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment