Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer using eval on assert operator #386 #395

Merged

Conversation

@christophertrml
Copy link

@christophertrml christophertrml commented Mar 8, 2015

This pull request fixes issue #386 . The use of eval has gone away, and has been replaced with a switch operator on all possible boolean operators. I moved the error to the default case of the switch statement, as this avoids the unnecessary check in the beginning (and so that if more operators were added in the future, you wouldn't have to remember to add it in both places).

@keithamus
Copy link
Member

@keithamus keithamus commented Mar 8, 2015

Sweet! Nice work @cjqed!

keithamus added a commit that referenced this pull request Mar 8, 2015
No longer using eval on assert operator #386
@keithamus keithamus merged commit 83a9e56 into chaijs:master Mar 8, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants