Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer using eval on assert operator #386 #395

merged 1 commit into from
Mar 8, 2015


Copy link

@lexi-sh lexi-sh commented Mar 8, 2015

This pull request fixes issue #386 . The use of eval has gone away, and has been replaced with a switch operator on all possible boolean operators. I moved the error to the default case of the switch statement, as this avoids the unnecessary check in the beginning (and so that if more operators were added in the future, you wouldn't have to remember to add it in both places).

Copy link

Sweet! Nice work @cjqed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants