New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer using eval on assert operator #386 #395

Merged
merged 1 commit into from Mar 8, 2015

Conversation

Projects
None yet
2 participants
@christophertrml
Contributor

christophertrml commented Mar 8, 2015

This pull request fixes issue #386 . The use of eval has gone away, and has been replaced with a switch operator on all possible boolean operators. I moved the error to the default case of the switch statement, as this avoids the unnecessary check in the beginning (and so that if more operators were added in the future, you wouldn't have to remember to add it in both places).

@keithamus

This comment has been minimized.

Member

keithamus commented Mar 8, 2015

Sweet! Nice work @cjqed!

keithamus added a commit that referenced this pull request Mar 8, 2015

Merge pull request #395 from cjqed/386-assert-operator-no-eval
No longer using eval on assert operator #386

@keithamus keithamus merged commit 83a9e56 into chaijs:master Mar 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency chai to v4 #30

@dependabot dependabot bot referenced this pull request Mar 17, 2018

Merged

Bump chai from 3.5.0 to 4.1.2 #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment