New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `ownPropertyDescriptor` tests #422

Merged
merged 2 commits into from Apr 7, 2015

Conversation

Projects
None yet
2 participants
@ljharb
Contributor

ljharb commented Apr 7, 2015

Fixes #413

@keithamus

This comment has been minimized.

Member

keithamus commented Apr 7, 2015

Great work @ljharb 😄

But, can you drop the last commit please. make build is only run per-release.

@ljharb ljharb force-pushed the ljharb:fix_descriptor_tests branch from f14d997 to 517d463 Apr 7, 2015

@ljharb

This comment has been minimized.

Contributor

ljharb commented Apr 7, 2015

Done!

keithamus added a commit that referenced this pull request Apr 7, 2015

Merge pull request #422 from ljharb/fix_descriptor_tests
Fix `ownPropertyDescriptor` tests

@keithamus keithamus merged commit 55c5153 into chaijs:master Apr 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus

This comment has been minimized.

Member

keithamus commented Apr 7, 2015

👍

@ljharb

This comment has been minimized.

Contributor

ljharb commented Apr 8, 2015

Thanks!

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency chai to v4 #30

@dependabot dependabot bot referenced this pull request Mar 17, 2018

Merged

Bump chai from 3.5.0 to 4.1.2 #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment