Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ownPropertyDescriptor tests #422

Merged
merged 2 commits into from Apr 7, 2015
Merged

Conversation

@ljharb
Copy link
Contributor

@ljharb ljharb commented Apr 7, 2015

Fixes #413

@keithamus
Copy link
Member

@keithamus keithamus commented Apr 7, 2015

Great work @ljharb 😄

But, can you drop the last commit please. make build is only run per-release.

@ljharb ljharb force-pushed the ljharb:fix_descriptor_tests branch from f14d997 to 517d463 Apr 7, 2015
@ljharb
Copy link
Contributor Author

@ljharb ljharb commented Apr 7, 2015

Done!

keithamus added a commit that referenced this pull request Apr 7, 2015
Fix `ownPropertyDescriptor` tests
@keithamus keithamus merged commit 55c5153 into chaijs:master Apr 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus
Copy link
Member

@keithamus keithamus commented Apr 7, 2015

👍

@ljharb
Copy link
Contributor Author

@ljharb ljharb commented Apr 8, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants