New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #442 chai can't cope with AssertionErrors raised from node's assert #446

Merged
merged 1 commit into from Oct 2, 2015

Conversation

Projects
None yet
2 participants
@danielbprice

danielbprice commented May 15, 2015

I'm happy to implement some test cases for this PR, but despite several tries I had trouble figuring out how to mock up the exact scenario we hit with AssertionError in nodejs. If there's a way to implement nodejs specific tests, I can do that too.

keithamus added a commit that referenced this pull request Oct 2, 2015

Merge pull request #446 from danielbprice/master
Issue #442 chai can't cope with AssertionErrors raised from node's assert

@keithamus keithamus merged commit 7f5a108 into chaijs:master Oct 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Oct 2, 2015

Member

👍 sorry it took so long to merge @danielbprice

Member

keithamus commented Oct 2, 2015

👍 sorry it took so long to merge @danielbprice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment