New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moot `version` property from bower.json #468

Merged
merged 2 commits into from Jun 13, 2015

Conversation

Projects
None yet
2 participants
@kkirsche
Contributor

kkirsche commented Jun 12, 2015

@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Jun 12, 2015

Member

Thanks for the PR @kkirsche!

If we're going to merge this, you'll also need to exclude it from the Makefile bump utility on Makefile#L24, so change the line to something like

    ./node_modules/.bin/bump -y --$(1) package.json lib/chai.js

from

    ./node_modules/.bin/bump -y --$(1) *.json lib/chai.js
Member

keithamus commented Jun 12, 2015

Thanks for the PR @kkirsche!

If we're going to merge this, you'll also need to exclude it from the Makefile bump utility on Makefile#L24, so change the line to something like

    ./node_modules/.bin/bump -y --$(1) package.json lib/chai.js

from

    ./node_modules/.bin/bump -y --$(1) *.json lib/chai.js
@kkirsche

This comment has been minimized.

Show comment
Hide comment
@kkirsche

kkirsche Jun 12, 2015

Contributor

@keithamus pushed that change for you

Contributor

kkirsche commented Jun 12, 2015

@keithamus pushed that change for you

keithamus added a commit that referenced this pull request Jun 13, 2015

Merge pull request #468 from kkirsche/patch-1
Remove moot `version` property from bower.json

@keithamus keithamus merged commit 775281e into chaijs:master Jun 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Jun 13, 2015

Member

👍

Member

keithamus commented Jun 13, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment