New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests and expectations for NaN. Ex: expect(4).not.to.be.NaN;
#480
Conversation
Great work @bradcypert! Couple of notes:
Fix the above issues, and I'll be overjoyed to hit the big green merge button |
I've done everything excluding the rebase, however, my assert tests are failing against saucelabs, but running locally. Any chance you'd be interested in taking a look? |
Passing on travis, which is good enough for me |
Haha, fair enough. My git-fu is weak. How do I go about rebaseing to prevent my changes to chai.js? |
I don't have much time right now - but could help out maybe tomorrow. In the meantime you could read a tutorial, e.g. https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase. You just need to squash both commits and checkout the old copy of chai.js and then amend the commit with the older checked out copy. |
Squashed everything and reverted my incidental change to Chai.js |
Great work @bradcypert |
Added tests and expectations for NaN. Ex: `expect(4).not.to.be.NaN;`
|
@screendriver it will be soon. The docs are pretty badly out of date but we're working on them |
|
Added support for NaN as per @keithamus comment on issue #477
I agree. I think the
to.be.NaN;
structure is what makes the most sense for this issue.