Fixing a typo in the `getProperties()` utility #485

Merged
merged 1 commit into from Jul 17, 2015

Projects

None yet

2 participants

@jluchiji
Contributor

The subject should apparently be object.

My apologies for creating a new pull request..the last one disappeared due to me resetting my master branch. Previous PR is here: #483

As requested, I rebased all my commits and removed the chai.js build. I think it would be helpful to add these guidelines to the README file, since I saw quite a few people running into these when opening PRs.

@jluchiji jluchiji Fixing a typo in the `getProperties()` utility
...where `subject` should apparently be `object`.
6518071
@keithamus
Member

Yeah, adding better guidelines is on my long list of things to do. If you would like to submit a PR, I'd happily merge it 😉

As for this PR, thanks very much for your hard work.

@keithamus keithamus merged commit e4e439b into chaijs:master Jul 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment