New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a typo in the `getProperties()` utility #485

Merged
merged 1 commit into from Jul 17, 2015

Conversation

Projects
None yet
2 participants
@wyvernzora
Contributor

wyvernzora commented Jul 17, 2015

The subject should apparently be object.

My apologies for creating a new pull request..the last one disappeared due to me resetting my master branch. Previous PR is here: #483

As requested, I rebased all my commits and removed the chai.js build. I think it would be helpful to add these guidelines to the README file, since I saw quite a few people running into these when opening PRs.

Fixing a typo in the `getProperties()` utility
...where `subject` should apparently be `object`.
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Jul 17, 2015

Member

Yeah, adding better guidelines is on my long list of things to do. If you would like to submit a PR, I'd happily merge it 😉

As for this PR, thanks very much for your hard work.

Member

keithamus commented Jul 17, 2015

Yeah, adding better guidelines is on my long list of things to do. If you would like to submit a PR, I'd happily merge it 😉

As for this PR, thanks very much for your hard work.

keithamus added a commit that referenced this pull request Jul 17, 2015

Merge pull request #485 from jluchiji/master
Fixing a typo in the `getProperties()` utility

@keithamus keithamus merged commit e4e439b into chaijs:master Jul 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency chai to v4 #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment