New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened check for empty #499

Merged
merged 2 commits into from Jul 24, 2015

Conversation

Projects
None yet
2 participants
@Daio-io
Contributor

Daio-io commented Jul 24, 2015

  • Updated empty based on conversation on issue #472
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Jul 24, 2015

Member

Looks good, thanks @Daveloper87 😄

Member

keithamus commented Jul 24, 2015

Looks good, thanks @Daveloper87 😄

keithamus added a commit that referenced this pull request Jul 24, 2015

@keithamus keithamus merged commit 8aea7a5 into chaijs:master Jul 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

tusbar added a commit to tusbar/chai that referenced this pull request Oct 21, 2015

Revert .empty assertion change from PR #499
The change introduced in #499 breaks compatibility with Array-like
objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix #537

keithamus added a commit that referenced this pull request Oct 21, 2015

Merge pull request #538 from tusbar/tusbar/revert-499
Revert .empty assertion change from PR #499

lucasfcosta added a commit to lucasfcosta/chai that referenced this pull request Mar 14, 2016

Revert .empty assertion change from PR #499
The change introduced in #499 breaks compatibility with Array-like
objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix #537

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency chai to v4 #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment