Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened check for empty #499

Merged
merged 2 commits into from Jul 24, 2015
Merged

Conversation

@Daio-io
Copy link
Contributor

@Daio-io Daio-io commented Jul 24, 2015

  • Updated empty based on conversation on issue #472
Dai added 2 commits Jun 28, 2015
Dai
@keithamus
Copy link
Member

@keithamus keithamus commented Jul 24, 2015

Looks good, thanks @Daveloper87 😄

keithamus added a commit that referenced this pull request Jul 24, 2015
Shortened check for empty
@keithamus keithamus merged commit 8aea7a5 into chaijs:master Jul 24, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tusbar added a commit to tusbar/chai that referenced this pull request Oct 21, 2015
The change introduced in chaijs#499 breaks compatibility with Array-like
objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix chaijs#537
keithamus added a commit that referenced this pull request Oct 21, 2015
Revert .empty assertion change from PR #499
lucasfcosta added a commit to lucasfcosta/chai that referenced this pull request Mar 14, 2016
The change introduced in chaijs#499 breaks compatibility with Array-like
objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix chaijs#537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.