Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed expect('').to.contain('') so it passes #512

Merged
merged 1 commit into from Sep 11, 2015
Merged

Conversation

@dereke
Copy link
Contributor

@dereke dereke commented Sep 1, 2015

Found a bug when you are trying to assert against a blank string.
Test case and fix included

@keithamus
Copy link
Member

@keithamus keithamus commented Sep 1, 2015

Hey @dereke, thanks for the PR. Could you please rebase your commits so as not to include chai.js. It is built per-release and so shouldn't be built for individual PRs.

@dereke
Copy link
Contributor Author

@dereke dereke commented Sep 1, 2015

Hi @keithamus when we ran the tests without having build chai.js they failed.
Does CI build chai.js when the tests run?

@keithamus
Copy link
Member

@keithamus keithamus commented Sep 1, 2015

The CI does indeed run the tests: https://travis-ci.org/chaijs/chai/builds/78216305. Also, you're welcome to build chai.js as many times as you want locally, just don't commit it 😉

@dereke dereke force-pushed the dereke:master branch from a86a6e7 to eaba0be Sep 1, 2015
@dereke
Copy link
Contributor Author

@dereke dereke commented Sep 1, 2015

OK cool. all done.

@dereke
Copy link
Contributor Author

@dereke dereke commented Sep 11, 2015

@keithamus when do you think this will show up in a release?

@keithamus
Copy link
Member

@keithamus keithamus commented Sep 11, 2015

Thanks for reminding me @dereke. I'm going to look at this in a couple of hours and make a release in about 5 hours, which will be 3.2.0 (hopefully)

keithamus added a commit that referenced this pull request Sep 11, 2015
fixed expect('').to.contain('') so it passes
@keithamus keithamus merged commit cf9f5d9 into chaijs:master Sep 11, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dereke
Copy link
Contributor Author

@dereke dereke commented Sep 15, 2015

any chance of publishing the new package?

@keithamus
Copy link
Member

@keithamus keithamus commented Sep 21, 2015

@dereke this should be in 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.