fixed expect('').to.contain('') so it passes #512

Merged
merged 1 commit into from Sep 11, 2015

Projects

None yet

2 participants

@dereke
Contributor
dereke commented Sep 1, 2015

Found a bug when you are trying to assert against a blank string.
Test case and fix included

@keithamus
Member

Hey @dereke, thanks for the PR. Could you please rebase your commits so as not to include chai.js. It is built per-release and so shouldn't be built for individual PRs.

@dereke
Contributor
dereke commented Sep 1, 2015

Hi @keithamus when we ran the tests without having build chai.js they failed.
Does CI build chai.js when the tests run?

@keithamus
Member

The CI does indeed run the tests: https://travis-ci.org/chaijs/chai/builds/78216305. Also, you're welcome to build chai.js as many times as you want locally, just don't commit it 😉

@dereke
Contributor
dereke commented Sep 1, 2015

OK cool. all done.

@dereke
Contributor
dereke commented Sep 11, 2015

@keithamus when do you think this will show up in a release?

@keithamus
Member

Thanks for reminding me @dereke. I'm going to look at this in a couple of hours and make a release in about 5 hours, which will be 3.2.0 (hopefully)

@keithamus keithamus merged commit cf9f5d9 into chaijs:master Sep 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dereke
Contributor
dereke commented Sep 15, 2015

any chance of publishing the new package?

@keithamus
Member

@dereke this should be in 3.3.0

@marekventur marekventur referenced this pull request in Gamevy/pixi-packer Dec 14, 2015
Merged

Update "chai" to version ^3.4.1 #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment