Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack trace tracking for property asserts #514

Merged
merged 1 commit into from Sep 8, 2015

Conversation

@kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Sep 8, 2015

The ssfi parameter was not being updated for these methods, which ended up causing the trace to be omitted.

Fixes #358

The ssfi parameter was not being updated for these methods, which ended up causing the trace to be omitted.

Fixes #358
keithamus added a commit that referenced this pull request Sep 8, 2015
Fix stack trace tracking for property asserts
@keithamus keithamus merged commit 5044dc0 into chaijs:master Sep 8, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus
Copy link
Member

@keithamus keithamus commented Sep 8, 2015

Ahh @kpdecker you're my hero! I'm merging this and we'll look to close #358, #425 and #355 from it.

@pschuegr
Copy link

@pschuegr pschuegr commented Oct 1, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.