New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message string substitutions #570

Merged
merged 2 commits into from Dec 14, 2015

Conversation

Projects
None yet
2 participants
@jurko-gospodnetic
Contributor

jurko-gospodnetic commented Dec 14, 2015

This is a fix for issue #560.

Tests included.

I noticed the getMessage tests currently seem to be missing several getMessage() implementation features (e.g. how different objects get serialized to strings), but I did not go into implementing those here.

jurko-gospodnetic added some commits Dec 14, 2015

fix error message tag substitution
String.prototype.replace() had some extra undesireable substitution behaviour
when it replaces a tag with a string containing some internal tags like `$$`,
or `$'`.

For more detailed information see:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Dec 14, 2015

Member

Great work @jurko-gospodnetic 😄

Member

keithamus commented Dec 14, 2015

Great work @jurko-gospodnetic 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment