New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean browser before karma #575

Merged
merged 2 commits into from Dec 22, 2015

Conversation

Projects
None yet
2 participants
@lucasfcosta
Member

lucasfcosta commented Dec 21, 2015

Hi @keithamus, according to what we've been talking on #515, this is the Makefile I was using when making my changes. I avoided using lib/** as you said, instead I added the clean-browser task as a dependency of every browser's tests.

I've also edited CONTRIBUTING.md with clearer instructions according to the new Makefile.

I also have a doubt: are you guys planning on using Gulp? Personally, I think it would be more friendly both for different platforms (Windows doesn't have Make available, for example) and for JS programmers (which are used to this kind of task automation).

keithamus added a commit that referenced this pull request Dec 22, 2015

@keithamus keithamus merged commit a4b253d into chaijs:master Dec 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Dec 22, 2015

Member

Thanks for this @lucasfcosta 😄. I hope to get some time over the holidays to do some refactoring in a 5.x.x branch and will probably take a look at the build tasks at the same time. I'm not exactly the biggest fan of Gulp et al but I'd like to move to npm scripts for straightforwardness and windows compatibility.

Member

keithamus commented Dec 22, 2015

Thanks for this @lucasfcosta 😄. I hope to get some time over the holidays to do some refactoring in a 5.x.x branch and will probably take a look at the build tasks at the same time. I'm not exactly the biggest fan of Gulp et al but I'd like to move to npm scripts for straightforwardness and windows compatibility.

@lucasfcosta

This comment has been minimized.

Show comment
Hide comment
@lucasfcosta

lucasfcosta Dec 22, 2015

Member

Ah, sure, I totally understand your point of view and it seems very reasonable.
If you need any help with these things you can count on me!

Thank you too!

Member

lucasfcosta commented Dec 22, 2015

Ah, sure, I totally understand your point of view and it seems very reasonable.
If you need any help with these things you can count on me!

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment