Auto register side effects and Update documentation #872

Merged
merged 3 commits into from Nov 18, 2016

Projects

None yet

3 participants

@inancgumus
Contributor
inancgumus commented Nov 18, 2016 edited

An updating pull request for the new comments from the team: #868

There was an earlier commits for this work, then, this is updating it.

inancgumus added some commits Nov 18, 2016
@inancgumus inancgumus Update chai/{testing-style} to chai/register-{testing-style} f7bd43a
@inancgumus inancgumus Update documentation on registering side effects and remove module.ex…
…ports
a39d14c
@meeber
Contributor
meeber commented Nov 18, 2016

Thanks for the PR! Couple nits for consistency:

  • Switch Pre-Native Modules Usage (as local variables) examples to use single quotes instead of double.
  • Add a semicolon to both should() statements.
@inancgumus inancgumus Update README.md usage for minor consistency issues
8dce4ca
@inancgumus
Contributor

@meeber Thanks for reviewing. I updated it.

@meeber
Contributor
meeber commented Nov 18, 2016

LGTM!

@lucasfcosta
Member

LGTM too!

@lucasfcosta lucasfcosta merged commit 5a0aa59 into chaijs:master Nov 18, 2016

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment