Center repo name on README #889

Merged
merged 1 commit into from Dec 18, 2016

Projects

None yet

4 participants

@astorije
Member

I haven't taken any liberties regarding the name, but I have noticed it is sometimes "chai", "Chai", and I'm pretty sure I have seen "ChaiJS" somewhere. Might want to pick an official representation :)

Before After
screen shot 2016-12-18 at 00 01 58 screen shot 2016-12-18 at 00 03 37
@astorije astorije Center repo name on README
b866d1e
@astorije astorije added the docs label Dec 18, 2016
@keithamus
Member

LGTM 😀

@shvaikalesh
Member

LGTM, thanks @astorije

@lucasfcosta
Member
lucasfcosta commented Dec 18, 2016 edited

LGTM too! Thanks 😄

EDIT: LGTM seems to be down, so I'm gonna merge this since we've already approved this change.

@lucasfcosta lucasfcosta merged commit 104a6b7 into master Dec 18, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
@astorije astorije deleted the astorije/readme-fix branch Dec 18, 2016
@astorije
Member

I think I've seen LGTM down more often than not :D

Joke aside, have you thought about using a combination of GitHub reviews + protected branches with required checks? I think that would replace the need for LGTM fairly well.

@lucasfcosta
Member
lucasfcosta commented Dec 18, 2016 edited

@astorije I'd love to use that feature, but I think the biggest problem about it is not being able to configure how many approvals something should have before merging.

I think the review feature is awesome, but if a single person approves a change it can already be merged and that's what makes me not want to use it.

However if the rest of the team feels like we should start using it instead of LGTM I'd also be happy with this change.

@keithamus
Member

I think LGTM.co is down for good this time. So I think our hand has been forced. We could take the source for LGTM and host it ourselves but already saying that has exhausted me so I think switching to GitHub's internal review approval system is our only realistic option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment