Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove implementation frames from stack trace #922
Note to self: Rebase after #899 is merged and update to turn
This PR is split into five commits:
This was referenced
Jan 29, 2017
referenced this pull request
Feb 12, 2017
Awesome job! Very clean implementation.
I also liked the tests, I think they cover all the edge cases and general functioning of this change.
I think, however, that some minor details in docstrings and error messages should be changed.
I left a few other comments throughout the code with suggestions and my thoughts on this matter.
I also tried to find any nested assertion invocations that did not set the
keep_ssfi flag but I couldn't find any.
Thanks for your work @meeber!
Pushed a new version. Changes:
Awesome job @meeber!
The variable name change was much better than what I suggested,
lock is really the right word for this. Very well thought.
Also, by reading the code I think that we have too many comments explaining simple tests, especially because some of them are almost identical versions of each other. IMO this adds unnecessary noise to the code and makes it more laborious to maintain (as I explained in another comment).
However, I won't reject these changes because of that, but please, if you agree with these opinions, let us know.
@keithamus @shvaikalesh @vieiralucas @lucasfcosta Rebased since #899 was merged. As expected, some
I think this PR is ready to go. After this is merged, there will be a follow-up PR related to messages.