New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert get version package json #986

Merged
merged 2 commits into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@lucasfcosta
Member

lucasfcosta commented Jun 1, 2017

This fixes #981 by not requiring a .json file inside our code in order for webpack not to need json-loader. This change was introduced #819.

This commit also reverts changes made at #967, because now we still need to bump the version in the lib/chai.js file.

Finally, since this seems a very important thing to release ASAP given the number of people using webpack1, I've added a commit that does this release.

@meeber

meeber approved these changes Jun 3, 2017

LGTM

@vieiralucas

This comment has been minimized.

Show comment
Hide comment
@vieiralucas

vieiralucas Jun 3, 2017

Member

Have we thought of doing something like JSON.parse(fs.readFileSync('../package.json')).version?

Anyways, since the build tools will bump this automatically, this LGTM.

Member

vieiralucas commented Jun 3, 2017

Have we thought of doing something like JSON.parse(fs.readFileSync('../package.json')).version?

Anyways, since the build tools will bump this automatically, this LGTM.

@vieiralucas vieiralucas merged commit 616cf8b into chaijs:master Jun 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dependabot dependabot bot referenced this pull request Mar 17, 2018

Merged

Bump chai from 3.5.0 to 4.1.2 #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment