Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert get version package json #986

Merged

Conversation

@lucasfcosta
Copy link
Member

lucasfcosta commented Jun 1, 2017

This fixes #981 by not requiring a .json file inside our code in order for webpack not to need json-loader. This change was introduced #819.

This commit also reverts changes made at #967, because now we still need to bump the version in the lib/chai.js file.

Finally, since this seems a very important thing to release ASAP given the number of people using webpack1, I've added a commit that does this release.

@meeber
meeber approved these changes Jun 3, 2017
Copy link
Contributor

meeber left a comment

LGTM

@vieiralucas
Copy link
Member

vieiralucas commented Jun 3, 2017

Have we thought of doing something like JSON.parse(fs.readFileSync('../package.json')).version?

Anyways, since the build tools will bump this automatically, this LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.