Revert get version package json#986
Merged
vieiralucas merged 2 commits intoJun 5, 2017
Merged
Conversation
Member
|
Have we thought of doing something like Anyways, since the build tools will bump this automatically, this LGTM. |
vieiralucas
approved these changes
Jun 3, 2017
This was referenced Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #981 by not requiring a
.jsonfile inside our code in order for webpack not to needjson-loader. This change was introduced #819.This commit also reverts changes made at #967, because now we still need to bump the version in the
lib/chai.jsfile.Finally, since this seems a very important thing to release ASAP given the number of people using webpack1, I've added a commit that does this release.