Skip to content

Conversation

@davelosert
Copy link
Member

With all the dazzle about the promises, i totally forgot about the other Spec we were talking with new String() returning type string instead of object. I changed that now and also added a test to make sure new Number() actually returns type number.

Sorry for this :D

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6867882 on Charminbear:string-object-as-string into 2892123 on chaijs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7ea0a92 on Charminbear:string-object-as-string into 2892123 on chaijs:master.

@keithamus
Copy link
Member

😄

keithamus added a commit that referenced this pull request Mar 14, 2015
"new String()" as 'string' instead of 'object'
@keithamus keithamus merged commit 5558a51 into chaijs:master Mar 14, 2015
@davelosert davelosert deleted the string-object-as-string branch March 14, 2015 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants