Skip to content

"new String()" as 'string' instead of 'object' #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keithamus merged 2 commits into from
Mar 14, 2015
Merged

"new String()" as 'string' instead of 'object' #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6867882
Made "new String()" return type "string" instead of object and added …
davelosert Mar 14, 2015
7ea0a92
Also updated the Docs with new Spec.
davelosert Mar 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,14 @@ assert(type(-1) === 'number');
assert(type(-1.234) === 'number');
assert(type(Infinity) === 'number');
assert(type(NaN) === 'number');
assert(type(new Number(1)) === 'number');
```

#### string

```js
assert(type('hello world') === 'string');
assert(type(new String('hello')) === 'object');
```

#### null
Expand All @@ -100,7 +102,6 @@ assert(type({}) === 'object');
assert(type(Noop) !== 'object');
assert(type(new Noop) === 'object');
assert(type(new Object) === 'object');
assert(type(new String('hello')) === 'object');
```

#### ECMA6 Types
Expand Down
2 changes: 0 additions & 2 deletions lib/type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ var objectTypeRegexp = /^\[object (.*)\]$/;
function getType(obj) {
var type = Object.prototype.toString.call(obj).match(objectTypeRegexp)[1].toLowerCase();
// Let "new String('')" return 'object'
if (type === 'string' && typeof obj === 'object') return 'object';
// Without support of @@toStringTag, Promise has type 'object'
if (typeof Promise === 'function' && obj instanceof Promise) return 'promise';
// PhantomJS has type "DOMWindow" for null
if (obj === null) return 'null';
Expand Down
3 changes: 2 additions & 1 deletion test/type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ describe('type(obj)', function () {
assert('number' === type(-1.234));
assert('number' === type(Infinity));
assert('number' === type(NaN));
assert('number' === type(new Number(2)));
});

it('string', function () {
assert('string' === type('hello world'));
assert('string' === type(new String('hello')));
});

it('null', function () {
Expand All @@ -52,7 +54,6 @@ describe('type(obj)', function () {
assert('object' !== type(Noop));
assert('object' === type(new Noop));
assert('object' === type(new Object));
assert('object' === type(new String('hello')));
});

describe('New ECMA6 Types Stubbed', function () {
Expand Down