core: wrap batch panics with stack trace #495

Merged
merged 2 commits into from Feb 8, 2017

Projects

None yet

3 participants

@jbowens
Member
jbowens commented Feb 8, 2017

When recovering a panic in a batch endpoint, wrap the panic with the
stack trace. Otherwise, the reported panic doesn't include a stack trace
and can be difficult to debug. Also, bump the number of frames that we
collect.

@jbowens jbowens added the PTAL label Feb 8, 2017
@kr
kr approved these changes Feb 8, 2017 View changes
@kr
Member
kr commented Feb 8, 2017

LGTM

jbowens added some commits Feb 8, 2017
@jbowens @chainbot jbowens core: wrap batch panics with stack trace
When recovering a panic in a batch endpoint, wrap the panic with the
stack trace. Otherwise, the reported panic doesn't include a stack trace
and can be difficult to debug.
d7807ae
@jbowens @chainbot jbowens moar frames plz
ff6ca24
@chainbot chainbot merged commit 100e3c3 into main Feb 8, 2017

3 checks passed

licence/cla Contributor License Agreement is signed.
Details
wercker/cored Wercker pipeline passed
Details
wercker/java Wercker pipeline passed
Details
@chainbot chainbot deleted the wrap-batch-panics branch Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment