core/coreunsafe: use config.Production #499

Merged
merged 1 commit into from Feb 9, 2017

Projects

None yet

3 participants

@jbowens
Member
jbowens commented Feb 9, 2017

Use config.Production instead of the more fragile expvar to protect
against a production environment.

@jbowens jbowens core/coreunsafe: use config.Production
Use `config.Production` instead of the more fragile expvar to protect
against a production environment.
5997b57
@jbowens jbowens added the PTAL label Feb 9, 2017
@kr
kr approved these changes Feb 9, 2017 View changes
@kr
Member
kr commented Feb 9, 2017

LGTM

@kr
Member
kr commented Feb 9, 2017

I would also like to explore having the prod build constraint arrange it so that this package doesn't even get linked in. (Checked in wercker using go tool nm or some other mechanism.)

@chainbot chainbot merged commit 1be1db3 into main Feb 9, 2017

3 checks passed

licence/cla Contributor License Agreement is signed.
Details
wercker/cored Wercker pipeline passed
Details
wercker/java Wercker pipeline passed
Details
@chainbot chainbot deleted the coreunsafe-isprod branch Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment