core/asset: ignore non-JSON asset definitions #509

Merged
merged 2 commits into from Feb 11, 2017

Projects

None yet

3 participants

@jbowens
Member
jbowens commented Feb 10, 2017

Chain Core won't allow assets to be created with non-JSON asset
definitions, but a buggy Chain Core or other clients on a network
may allow it. Instead of crashing the block processor, the error
should be ignored.

@jbowens jbowens added the PTAL label Feb 10, 2017
@kr
kr approved these changes Feb 10, 2017 View changes
@kr
Member
kr commented Feb 10, 2017

LGTM

jbowens added some commits Feb 10, 2017
@jbowens jbowens core/asset: ignore non-JSON asset definitions
Chain Core won't allow assets to be created with non-JSON asset
definitions, but a buggy Chain Core or other clients on a network
may allow it. Instead of crashing the block processor, the error
should be ignored.
7ae2c5a
@jbowens jbowens order matters!!!!
3a953c9
@chainbot chainbot merged commit 71dd256 into main Feb 11, 2017

3 checks passed

licence/cla Contributor License Agreement is signed.
Details
wercker/cored Wercker pipeline passed
Details
wercker/java Wercker pipeline passed
Details
@chainbot chainbot deleted the nonjson-asset-defs branch Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment