Readme: better support for multi-entry GOPATH #515

Merged
merged 1 commit into from Feb 13, 2017

Projects

None yet

3 participants

@kr
Member
kr commented Feb 13, 2017

Using 'go list' here does the right thing when GOPATH
has more than one directory in it. (There are still one
or two other places in this document that won't work
correctly in that scenario, but they are harder to fix.)

@kr kr Readme: better support for multi-entry GOPATH
Using 'go list' here does the right thing when GOPATH
has more than one directory in it. (There are still one
or two other places in this document that won't work
correctly in that scenario, but they are harder to fix.)
aa720fb
@kr kr added the PTAL label Feb 13, 2017
@kr
Member
kr commented Feb 13, 2017

PTAL

to `$CHAIN/vendor/x`. For example, to vendor the package
`github.com/kr/pretty`, run
```
$ mkdir -p $CHAIN/vendor/github.com/kr
$ rm -r $CHAIN/vendor/github.com/kr/pretty
-$ cp -r $(go env GOPATH)/src/github.com/kr/pretty $CHAIN/vendor/github.com/kr/pretty
+$ cp -r $(go list -f {{.Dir}} github.com/kr/pretty) $CHAIN/vendor/github.com/kr/pretty
@bobg
bobg Feb 13, 2017 Contributor

😮

@bobg
bobg approved these changes Feb 13, 2017 View changes
@bobg
Contributor
bobg commented Feb 13, 2017

LGTM

@chainbot chainbot merged commit c2ba318 into main Feb 13, 2017

3 checks passed

licence/cla Contributor License Agreement is signed.
Details
wercker/cored Wercker pipeline passed
Details
wercker/java Wercker pipeline passed
Details
@chainbot chainbot deleted the nit branch Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment