docs/protocol/specifications: specify Merkle Patricia Tree as a set #541

Merged
merged 5 commits into from Feb 16, 2017

Projects

None yet

3 participants

@kr
Member
kr commented Feb 16, 2017

No description provided.

@kr kr requested a review from oleganza Feb 16, 2017
@kr
Member
kr commented Feb 16, 2017
@kr kr removed the blockchain reset label Feb 16, 2017
@kr
Member
kr commented Feb 16, 2017

PTAL

docs/protocol/specifications/data.md
+Note that the resulting merkle patricia tree may not be balanced; however, its shape is uniquely determined by the number of leaves.
@oleganza
oleganza Feb 16, 2017 Member

the shape is uniquely determined by both the number of leaves and their content.

kr added some commits Feb 16, 2017
@kr kr fix formatting
ab8b440
@kr kr determined by data, not just n
176ae58
@kr
Member
kr commented Feb 16, 2017

Addressed feedback, PTAL.

@oleganza

Apart from the redundant note on "one or more per asset id", LGTM

docs/protocol/specifications/data.md
-Key | Value
-------------------------|------------------------------
-[Output ID](#output-id) | [Output ID](#output-id)
+The tree contains the list of the [Output IDs](#output-id) of all [non-retired](#retired-asset) unspent outputs (one or more per [asset ID](#asset-id)).
@oleganza
oleganza Feb 16, 2017 edited Member

I think my note on "one or more per asset ID" was redundant and distracting all this time.

kr added some commits Feb 16, 2017
@kr kr remove redundant (and confusing) note as requested 010172a
@kr kr wth, wercker
ef32c9d
@chainbot chainbot merged commit f785766 into main Feb 16, 2017

3 checks passed

licence/cla Contributor License Agreement is signed.
Details
wercker/cored Wercker pipeline passed
Details
wercker/java Wercker pipeline passed
Details
@chainbot chainbot deleted the set branch Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment