New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent (and slightly odd) directory tree about #2982

Closed
fiarabbit opened this Issue Jul 9, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@fiarabbit
Copy link
Contributor

fiarabbit commented Jul 9, 2017

In chainer project, usually, example classes of "hoge" are arranged under directory named "hoges".
examples:

import chainer
iteratorExample=chainer.iterators.SerialIterator
import chainer.training.extensions
extensionExample=chainer.training.extensions.Evaluator

However, example classes of updater are arranged under a module named "updater"

import chainer.training.updater
updaterExample=chainer.training.updater.StandardUpdater

And only MultiprocessParallelUpdater is arranged under a directory named "updaters"

import chainer.training.updaters
updaterExample2=chainer.training.updaters.MultiprocessParallelUpdater

I feel some inconsistency and inconvenience here, I wish all examples of updater are arranged under the "updaters" directory.

  • Conditions
    • Chainer version
      Chainer v2.0.1
  • Code to reproduce
import chainer
iteratorExamples=chainer.iterators.SerialIterator # OK
import chainer.training.extensions
extensionExamples=chainer.training.extensions.Evaluator # OK
import chainer.training.updaters
updaterExample1=chainer.training.updaters.MultiprocessParallelUpdater # OK
# updaterExample2=chainer.training.updaters.StandardUpdater # NG
import chainer.training.updater
updaterExample2=chainer.training.updater.StandardUpdater #OK
@delta2323

This comment has been minimized.

Copy link
Member

delta2323 commented Jul 18, 2017

I created a PR to solve the issue.

@delta2323 delta2323 self-assigned this Jul 24, 2017

@stale

This comment has been minimized.

Copy link

stale bot commented Oct 23, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 23, 2017

@stale

This comment has been minimized.

Copy link

stale bot commented Nov 22, 2017

This issue is closed as announced. Feel free to re-open it if needed.

@stale stale bot closed this Nov 22, 2017

@niboshi

This comment has been minimized.

Copy link
Member

niboshi commented Nov 22, 2017

Reopening, as the PR is still open.

@niboshi niboshi reopened this Nov 22, 2017

@stale stale bot removed the stale label Nov 22, 2017

@mitmul mitmul closed this in #3037 Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment