New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert inputs of batchnormalization.backward() to be C-contiguous (master) #2582

Merged
merged 2 commits into from Apr 18, 2017

Conversation

Projects
None yet
2 participants
@soramichi
Contributor

soramichi commented Apr 17, 2017

Changed the target branch of #2580 to master.

Also I added tests that use non-c-contiguous inputs as suggested in the comments in #2580. A new argument (param_shape = (3,)) is added because cudnn is used only if x.ndim == 4 and head_ndim == 2, which requires len(param_shape) == 1 (or if x.ndim == 2, which requires param_shape == () but it causes some inconsistency with the existing test codes).

@unnonouno unnonouno self-assigned this Apr 18, 2017

@unnonouno unnonouno added this to the v1.24.0 milestone Apr 18, 2017

@unnonouno unnonouno added the bug label Apr 18, 2017

@unnonouno unnonouno merged commit 6b42d0d into chainer:master Apr 18, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@unnonouno

This comment has been minimized.

Member

unnonouno commented Apr 18, 2017

Thank you!

@soramichi soramichi deleted the soramichi:batchnorm_c_contiguous branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment