New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make variable names consistent #2665

Merged
merged 1 commit into from Apr 30, 2017

Conversation

Projects
None yet
3 participants
@soramichi
Contributor

soramichi commented Apr 30, 2017

A tensor descriptor for xji should be named xji_desc, but not x_desc, to be consistent with the names used in other places like here.

@delta2323

This comment has been minimized.

Member

delta2323 commented Apr 30, 2017

LGTM, I'm running GPU test.

@delta2323 delta2323 self-assigned this Apr 30, 2017

@delta2323 delta2323 added this to the v1.24.0 milestone Apr 30, 2017

@delta2323 delta2323 merged commit ebdbaa4 into chainer:master Apr 30, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on 2665-fix-desc-name at 86.549%
Details
@delta2323

This comment has been minimized.

Member

delta2323 commented Apr 30, 2017

Thank you!

@soramichi soramichi deleted the soramichi:fix_desc_name branch May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment