Renew the readme #2692
Merged
Renew the readme #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitmul
requested changes
May 18, 2017
README.md
Outdated
| yum install hdf5-devel | ||
| ``` | ||
| Any contributions to Chainer are welcome! | ||
| If you want to file an issue or send a pull request, [follow the contribution guide](https://docs.chainer.org/contribution.html). |
There was a problem hiding this comment.
"please follow" would be more polite?
README.md
Outdated
| | Examples ([Official](https://github.com/pfnet/chainer/blob/master/examples), [External](https://github.com/pfnet/chainer/wiki/External-examples)) | ||
| | Forum ([en](https://groups.google.com/forum/#!forum/chainer), [ja](https://groups.google.com/forum/#!forum/chainer-jp)) | ||
| | Slack ([en](https://bit.ly/chainer-slack), [ja](https://bit.ly/chainer-jp-slack)) | ||
| | Twitter ([en](https://twitter.com/ChainerOfficial), [ja](https://twitter.com/ChainerJP)) | ||
|
|
There was a problem hiding this comment.
How about making these links bold style? It could be hard for some people to notice.
# Conflicts: # README.md
|
Fixed following your suggestions, and merged the latest v2. |
mitmul
approved these changes
May 25, 2017
|
LGTM |
This was referenced Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the readme for v2. It is simpler than the current one and easier to find the appropriate place to get the information that users want (which is the most important thing that readme should provide).