Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] fix test tolerance for F.fmod double backward test #3838

Merged
merged 1 commit into from Nov 10, 2017
Merged

[backport] fix test tolerance for F.fmod double backward test #3838

merged 1 commit into from Nov 10, 2017
+2 −1

Conversation

hvy
Copy link
Member

@hvy hvy commented Nov 10, 2017

Backport of #3837

@hvy
Merge pull request chainer#3837 from kmaehashi/fix-fmod-tolerance
2b1a25b 
fix test tolerance for F.fmod double backward test
@hvy hvy added backport Pull request that is backported from a more recent version. cat:test Test or CI related. labels Nov 10, 2017
@hvy hvy requested a review from kmaehashi November 10, 2017 07:32
@kmaehashi kmaehashi self-assigned this Nov 10, 2017
@kmaehashi
Copy link
Member

LGTM, will merge after AppVeyor pass.

@kmaehashi kmaehashi merged commit 7b74bbb into chainer:v3 Nov 10, 2017
@kmaehashi
Copy link
Member

LGTM!

@kmaehashi kmaehashi added this to the v3.1.0 milestone Nov 10, 2017
@hvy hvy deleted the bp-3837-fix-fmod-tolerance branch November 10, 2017 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi Awaiting requested review from kmaehashi

Assignees

@kmaehashi kmaehashi

Labels
backport Pull request that is backported from a more recent version. cat:test Test or CI related.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hvy @kmaehashi