Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backward test for old-styled sclar variable #4416

Merged
merged 1 commit into from Feb 28, 2018
Merged

add backward test for old-styled sclar variable #4416

merged 1 commit into from Feb 28, 2018

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented Feb 27, 2018 •
edited

Add tests for features deprecated in #4199.

@kmaehashi kmaehashi added this to the v4.0.0rc1 milestone Feb 27, 2018
@kmaehashi kmaehashi added the cat:test Test or CI related. label Feb 27, 2018
@niboshi
Copy link
Member

niboshi commented Feb 28, 2018

How about using pytest-style asserts?
(assert, pytest.raises)

@niboshi niboshi self-assigned this Feb 28, 2018
@niboshi
Copy link
Member

niboshi commented Feb 28, 2018

Ah, I see. It's aligned with other asserts in the same file.

@niboshi
Copy link
Member

niboshi commented Feb 28, 2018

LGTM!

@niboshi niboshi merged commit b18b68d into chainer:master Feb 28, 2018
@kmaehashi kmaehashi deleted the add-one-element-scalar-test branch March 1, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:test Test or CI related.
Projects
None yet
Milestone
v4.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmaehashi @niboshi