Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Avoid mutable default arguments #4600

Merged
merged 1 commit into from Apr 16, 2018
Merged

[backport] Avoid mutable default arguments #4600

merged 1 commit into from Apr 16, 2018

Conversation

kmaehashi
Copy link
Member

Backport of #4419

@kmaehashi kmaehashi added backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces. labels Apr 10, 2018
@mitmul
Copy link
Member

mitmul commented Apr 16, 2018

Jenkins, test this please

@mitmul
Copy link
Member

mitmul commented Apr 16, 2018

LGTM

@mitmul mitmul merged commit 623f4e5 into chainer:v4 Apr 16, 2018
@kmaehashi kmaehashi deleted the bp-4419-mutable-default-arguments branch April 17, 2018 01:07
@kmaehashi kmaehashi added this to the v4.0.0 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmaehashi @mitmul