Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eps_inside_sqrt option to RMSprop #5150

Merged
merged 1 commit into from Aug 1, 2018

Conversation

@kmaehashi
Copy link
Member

commented Jul 25, 2018

Fix #4754.

@kmaehashi kmaehashi added this to the v5.0.0b4 milestone Jul 25, 2018
Copy link
Member

left a comment

LGTM

@toslunar

This comment has been minimized.

Copy link
Member

commented Jul 27, 2018

Jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Jenkins CI test (for commit 5c48e9d, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@kmaehashi

This comment has been minimized.

Copy link
Member Author

commented Jul 27, 2018

Jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Jenkins CI test (for commit 5c48e9d, target branch master) succeeded!

@toslunar toslunar self-assigned this Aug 1, 2018
@toslunar toslunar merged commit 3600ab5 into chainer:master Aug 1, 2018
4 checks passed
4 checks passed
codecov/patch 93.33% of diff hit (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 89.477%
Details
@kmaehashi kmaehashi deleted the kmaehashi:rmsprop-eps branch Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.