Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ndtr and log_ndtr in normal distribution #5240

Merged
merged 1 commit into from Aug 20, 2018

Conversation

gwtnb
Copy link
Member

@gwtnb gwtnb commented Aug 16, 2018

log_ndtr is used to avoid overflow and underflow. ndtr is for consistency.

@gwtnb
Copy link
Member Author

gwtnb commented Aug 16, 2018

This PR depends on #5237 and #5239.

@gwtnb gwtnb force-pushed the normal-ndtr branch 3 times, most recently from 0a06dfc to af53816 Compare August 20, 2018 07:51
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added the cat:enhancement Implementation that does not break interfaces. label Aug 20, 2018
@toslunar toslunar self-assigned this Aug 20, 2018
@toslunar
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit d2f51f3, target branch master) succeeded!

@toslunar toslunar changed the title Use ndtr and log_ndtr in normal distribution Use ndtr and log_ndtr in normal distribution Aug 20, 2018
@toslunar toslunar merged commit 92a288c into chainer:master Aug 20, 2018
@kmaehashi kmaehashi added this to the v5.0.0b4 milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants