Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link #5358

Merged
merged 2 commits into from Sep 25, 2018
Merged

Fix dead link #5358

merged 2 commits into from Sep 25, 2018

Conversation

keisuke-umezawa
Copy link
Member

No description provided.

Copy link
Member

@mitmul mitmul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you check my comment?

@@ -17,7 +17,7 @@ Chainer is a rapidly growing neural network platform. The strengths of Chainer a
Mushrooms -- tasty or deathly?
------------------------------

Let's take a look at a basic program of Chainer to see how it works. For a dataset, we'll work with `Kaggle's edible vs. poisonous mushroom dataset <https://www.kaggle.com/uciml/mushroom-classification>`_, which has over 8,000 examples of mushrooms, labelled by 22 categories including odor, cap color, habitat, etc., in a `mushrooms.csv file <https://raw.githubusercontent.com/chainer/chainer/master/docs/source/mushrooms.csv>`_.
Let's take a look at a basic program of Chainer to see how it works. For a dataset, we'll work with `Kaggle's edible vs. poisonous mushroom dataset <https://www.kaggle.com/uciml/mushroom-classification>`_, which has over 8,000 examples of mushrooms, labelled by 22 categories including odor, cap color, habitat, etc., in a `mushrooms.csv file <https://www.kaggle.com/uciml/mushroom-classification#mushrooms.csv>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keisuke-umezawa
Copy link
Member Author

@mitmul I fixed as you said!

@toslunar
Copy link
Member

LGTM.

#5316 caused the issue. Sorry.

@toslunar toslunar added the cat:document Documentation such as function documentations, comments and tutorials. label Sep 17, 2018
@mitmul
Copy link
Member

mitmul commented Sep 20, 2018

Jenkins, test this please

@mitmul mitmul self-assigned this Sep 20, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit cfb497c, target branch master) succeeded!

@mitmul
Copy link
Member

mitmul commented Sep 25, 2018

LGTM

@mitmul mitmul merged commit 6b70eb8 into chainer:master Sep 25, 2018
@mitmul mitmul added this to the v5.0.0rc1 milestone Sep 25, 2018
@keisuke-umezawa keisuke-umezawa deleted the fix/dead-link-glance branch September 25, 2018 05:23
@kmaehashi kmaehashi added the to-be-backported Pull request that should be backported. label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants