Change default scales to 1.0 #5507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toslunar
force-pushed
the
initializers-1.0
branch
from
1925c4f
to
3270dd0
Compare
|
The tests are too weak. Merge #5511 first. |
kmaehashi
added
the
cat:enhancement
beam2d
reviewed
Oct 30, 2018
|
We should discuss if it is ok to introduce this change immediately. Raising a warning when |
Co-Authored-By: toslunar <tos.lunar@gmail.com>
|
Added warnings. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
|
This issue is closed as announced. Feel free to re-open it if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default scales should be
1.0.Just in case, I added a config option to make them legacy.