Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for link, link_hook, Initializer and chainerx #5675

Merged
merged 39 commits into from Dec 29, 2018

Conversation

@okapies
Copy link
Member

okapies commented Nov 16, 2018

  • Add mypy to CI scripts
  • Add type hints to chainer.link, chainer.link_hook, chainer.Initializer and chainerx
  • Add type aliases (???Spec) to chainer.types
  • Add Protocols for each Hyperparameters
  • Define mocks of Device, Stream and Event in chainer.backends.cuda for non-CUDA environment
  • Make DummyDeviceType the subtype of cuda.Device for the type checker
  • Fix many type errors
okapies added 3 commits Nov 13, 2018
chainer/link.py Outdated Show resolved Hide resolved
@okuta

This comment has been minimized.

Copy link
Member

okuta commented Nov 25, 2018

Can you add type testing?

@okapies okapies force-pushed the okapies:feature/typing-link branch from 9f350d6 to f656810 Dec 6, 2018
@okapies okapies changed the title WIP: Add type hints for chainer.link and link_hook Add type hints for link, link_hook, Initializer and chainerx Dec 7, 2018
@okapies okapies force-pushed the okapies:feature/typing-link branch from d73a3ef to 676a3c8 Dec 10, 2018
@okapies

This comment has been minimized.

Copy link
Member Author

okapies commented Dec 11, 2018

@okuta Fixed based on your comment. Could you check again?

@okuta

This comment has been minimized.

Copy link
Member

okuta commented Dec 23, 2018

LGTM.
Please resolve conflicts.
jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

chainer-ci commented Dec 23, 2018

Jenkins CI test (for commit ea24d6c, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@okapies

This comment has been minimized.

Copy link
Member Author

okapies commented Dec 25, 2018

@okuta Thanks. I resolved conflicts and fixed misconfiguration of mypy installation on Jenkins. Could you please check it again?

@okuta

This comment has been minimized.

Copy link
Member

okuta commented Dec 26, 2018

jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

chainer-ci commented Dec 26, 2018

Jenkins CI test (for commit 65a0efb, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@okapies

This comment has been minimized.

Copy link
Member Author

okapies commented Dec 27, 2018

@okuta Fixed the conflict again. Could you run the test again?

@okuta

This comment has been minimized.

Copy link
Member

okuta commented Dec 27, 2018

jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

chainer-ci commented Dec 27, 2018

Jenkins CI test (for commit d59e4f4, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

chainer-ci commented Dec 27, 2018

Jenkins CI test (for commit ${ghprbActualCommit}, target branch ${ghprbTargetBranch}) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@okuta

This comment has been minimized.

Copy link
Member

okuta commented Dec 29, 2018

LGTM!

@okuta okuta merged commit cc53020 into chainer:master Dec 29, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@okapies

This comment has been minimized.

Copy link
Member Author

okapies commented Jan 7, 2019

@okuta Thanks so much!

@okapies okapies deleted the okapies:feature/typing-link branch Jan 7, 2019
@chainer-ci

This comment has been minimized.

Copy link
Collaborator

chainer-ci commented Jan 7, 2019

Jenkins CI test (for commit 3d63172, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.