Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise CuPy not available error early in cuda.GpuDevice initialization #5780

Merged
merged 1 commit into from Dec 7, 2018

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Dec 5, 2018

If CuPy is not available, Device is not defined, causing a bit difficult to understand error.

@niboshi niboshi added the cat:enhancement Implementation that does not break interfaces. label Dec 5, 2018
@hvy hvy self-assigned this Dec 6, 2018
@hvy
Copy link
Member

hvy commented Dec 6, 2018

jenkins, test this please.

@hvy hvy added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Dec 6, 2018
@hvy hvy added this to the v6.0.0b2 milestone Dec 6, 2018
@hvy
Copy link
Member

hvy commented Dec 6, 2018

jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0519c99, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@hvy
Copy link
Member

hvy commented Dec 6, 2018

jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0519c99, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@niboshi niboshi changed the title Raise CuPy not available error early in cuda.GpuDevice initialization Raise CuPy not available error early in cuda.GpuDevice initialization Dec 6, 2018
@hvy
Copy link
Member

hvy commented Dec 7, 2018

jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 0519c99, target branch master) succeeded!

@hvy
Copy link
Member

hvy commented Dec 7, 2018

LGTM!

@hvy hvy merged commit 78ca338 into chainer:master Dec 7, 2018
@niboshi niboshi deleted the gpu-device-early-error branch December 7, 2018 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants