Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inject_backend_tests multi_gpu test mark #6028

Merged
merged 1 commit into from Jan 19, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Jan 18, 2019

#5904 has caused testing.attr.multi_gpu (put by inject_backend_tests) to ignore CHAINER_TEST_GPU_LIMIT environment variable. This PR fixes it.

(just for reference)
Another fix would be to change unittest.skipIf to pytest.mark.skipif at this line (I don't know why):

return unittest.skipIf(

@niboshi niboshi added the cat:test Test or CI related. label Jan 18, 2019
@niboshi niboshi changed the title Fix gpu and multi_gpu test marks Fix inject_backend_tests multi_gpu test marks Jan 18, 2019
@niboshi niboshi changed the title Fix inject_backend_tests multi_gpu test marks Fix inject_backend_tests multi_gpu test marks Jan 18, 2019
@niboshi niboshi changed the title Fix inject_backend_tests multi_gpu test marks Fix inject_backend_tests multi_gpu test mark Jan 18, 2019
@okuta okuta added this to the v6.0.0b2 milestone Jan 19, 2019
@okuta okuta self-assigned this Jan 19, 2019
@okuta
Copy link
Member

okuta commented Jan 19, 2019

jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit d46b091, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@okuta
Copy link
Member

okuta commented Jan 19, 2019

LGTM!

@okuta okuta merged commit b5ceb1f into chainer:master Jan 19, 2019
@niboshi niboshi deleted the fix-gpu-attr branch January 19, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants