[chainerx] Implement Relu in c++ #6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asi1024
requested changes
Apr 3, 2019
asi1024
reviewed
Apr 3, 2019
asi1024
requested changes
Apr 4, 2019
asi1024
reviewed
Apr 4, 2019
|
|
||
|
|
||
| def relu(x): | ||
| """Rectified Linear Unit function. |
There was a problem hiding this comment.
Could you move this comment to chainerx/_docs/routines.py?
Co-Authored-By: dido1998 <adidolkar123@gmail.com>
|
@dido1998 Travis test seems to fail for a dtype mismatch. Could you fix it? |
|
I will check it out today. |
asi1024
added
the
st:awaiting-author
asi1024
requested changes
Apr 11, 2019
| # Special shapes | ||
| chainer.testing.product({ | ||
| 'shape': [(), (0,), (1,), (2, 0, 3), (1, 1, 1), (2, 3)], | ||
| 'in_dtypes,out_dtype': _in_out_float_dtypes_math_functions, |
There was a problem hiding this comment.
Why not testing also with integer dtypes?
Suggested change
| 'in_dtypes,out_dtype': _in_out_float_dtypes_math_functions, | |
| 'in_dtypes,out_dtype': _in_out_dtypes_math_functions, |
|
I have made the requested changes. |
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 421616a, target branch master) failed with status FAILURE. |
asi1024
removed
the
st:awaiting-author
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 421616a, target branch master) failed with status FAILURE. |
|
LGTM. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:
chainer/chainerx/activation.py
Line 17 in 077fdb1