Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Support ChainerX in word2vec example #6795

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@asi1024
Copy link
Member

commented Apr 8, 2019

Backport of #6774

@asi1024

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

[automatic post] Jenkins, test this please.

@asi1024 asi1024 added this to the v6.0.0 milestone Apr 8, 2019

@asi1024

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

Resolved two conflicts:

 <<<<<<< HEAD
     if args.gpu >= 0:
         chainer.backends.cuda.get_device_from_id(args.gpu).use()
         cuda.check_cuda_available()

     print('GPU: {}'.format(args.gpu))
 =======
     device = chainer.get_device(args.device)
     device.use()

     if args.snapshot_interval is None:
         args.snapshot_interval = args.epoch
     args.snapshot_interval = min(args.snapshot_interval, args.epoch)

     print('Device: {}'.format(device))
 >>>>>>> 16aa002e9... Merge pull request #6774 from niboshi/chainerx-word2vec-example
 <<<<<<< HEAD
     if args.gpu >= 0:
         model.to_gpu()
 =======
     model.to_device(device)
 >>>>>>> 16aa002e9... Merge pull request #6774 from niboshi/chainerx-word2vec-example
@chainer-ci

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

Jenkins CI test (for commit 03f5bd1, target branch v6) failed with status FAILURE.

@niboshi niboshi self-assigned this Apr 9, 2019

@niboshi

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Please fix test failure:

21:22:34 Running word2vec example
21:22:35 + echo 'Running word2vec example'
21:22:35 + coverage run -a --branch examples/word2vec/train_word2vec.py -e 1 -b 10 --test
21:22:35 Traceback (most recent call last):
21:22:35   File "examples/word2vec/train_word2vec.py", line 275, in <module>
21:22:35     main()
21:22:35   File "examples/word2vec/train_word2vec.py", line 189, in main
21:22:35     if args.snapshot_interval is None:
21:22:35 AttributeError: 'Namespace' object has no attribute 'snapshot_interval'
Merge pull request #6774 from niboshi/chainerx-word2vec-example
Support ChainerX in word2vec example

@asi1024 asi1024 force-pushed the asi1024:bp-6774-chainerx-word2vec-example branch from 03f5bd1 to 83fd720 Apr 9, 2019

@asi1024

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Fixed. Jenkins, test this please.

@pfn-ci-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

Successfully created a job for commit 83fd720:

@chainer-ci

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

Jenkins CI test (for commit 83fd720, target branch v6) failed with status FAILURE.

@niboshi

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

LGTM

@niboshi niboshi merged commit 1ee3e87 into chainer:v6 Apr 10, 2019

4 of 5 checks passed

Jenkins Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on bp-6774-chainerx-word2vec-example at 88.347%
Details
pfn-public-ci/chainer.py27and35 test succeeded
Details
pfn-public-ci/chainer.py37 test succeeded
Details

@asi1024 asi1024 deleted the asi1024:bp-6774-chainerx-word2vec-example branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.