Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F.clipped_relu test for NumPy 1.17 #7842

Merged
merged 1 commit into from Aug 2, 2019
Merged

Fix F.clipped_relu test for NumPy 1.17 #7842

merged 1 commit into from Aug 2, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Aug 1, 2019

Part of #7741

From NumPy 1.17, x.clip(0, self.z) returns float64 array even if x.dtype is float16.

@toslunar toslunar mentioned this pull request Aug 1, 2019
Closed
12 tasks
@niboshi niboshi added prio:high High priority. Urgent and needs to be worked on as soon as possible. release-blocker Pull request that is mandatory for a release. labels Aug 1, 2019
@niboshi niboshi added this to the v7.0.0b3 milestone Aug 1, 2019
@niboshi niboshi added the to-be-backported Pull request that should be backported. label Aug 1, 2019
toslunar
toslunar approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added the cat:test Test or CI related. label Aug 1, 2019
@toslunar toslunar self-assigned this Aug 1, 2019
This was referenced Aug 1, 2019
Merged
Merged
@toslunar
Copy link
Member

toslunar commented Aug 2, 2019

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 36d7a9b, target branch master) succeeded!

@toslunar toslunar added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Aug 2, 2019
@toslunar toslunar merged commit dd46688 into chainer:master Aug 2, 2019
@toslunar toslunar mentioned this pull request Aug 2, 2019
Merged
toslunar added a commit to toslunar/chainer that referenced this pull request Aug 2, 2019
@toslunar
Merge pull request chainer#7842 from niboshi/fix-clipped-relu-test-nu…
3e96aad 
…mpy117

Fix `F.clipped_relu` test for NumPy 1.17
@niboshi niboshi deleted the fix-clipped-relu-test-numpy117 branch August 2, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
cat:test Test or CI related. prio:high High priority. Urgent and needs to be worked on as soon as possible. release-blocker Pull request that is mandatory for a release. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0b3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niboshi @toslunar @chainer-ci