Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style in _snapshot.py #8297

Merged
merged 3 commits into from Nov 12, 2019
Merged

Fix style in _snapshot.py #8297

merged 3 commits into from Nov 12, 2019

Conversation

toslunar
Copy link
Member

The PR amends #8074.

@toslunar toslunar added the cat:code-fix Code refactoring that does not change the behavior. label Oct 15, 2019
@Crissman
Copy link
Member

imosCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit afea316, target branch master) succeeded!

himkt
himkt approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@himkt himkt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my missings in PR. 🙇
@Crissman friendly ping.

@Crissman Crissman merged commit dd7a9de into chainer:master Nov 12, 2019
@toslunar toslunar deleted the misc-8074 branch November 12, 2019 08:45
@toslunar toslunar added this to the v7.0.0 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himkt himkt himkt approved these changes

Assignees

@Crissman Crissman

Labels
cat:code-fix Code refactoring that does not change the behavior.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toslunar @Crissman @chainer-ci @himkt