Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError in WrappedFunctionNode.forward #8397

Merged
merged 2 commits into from Nov 14, 2019
Merged

Fix AttributeError in WrappedFunctionNode.forward #8397

merged 2 commits into from Nov 14, 2019

Conversation

msakai
Copy link
Contributor

@msakai msakai commented Nov 8, 2019

This PR fixes AttributeError in onnx_chainer.replace_func.WrappedFunctionNode.forward.
The self.name is not defined and I assume that this is a mistake of self.custom_function_node_name.

@toslunar toslunar added the ONNX Related to ONNX label Nov 8, 2019
disktnk
disktnk approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@disktnk disktnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! It's correction omission among development, thx. (but the line is over 79 char..?)

@take-cheeze
Copy link
Member

Jenkins, test this please!

take-cheeze
take-cheeze approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! 👍

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 11, 2019
@take-cheeze take-cheeze self-assigned this Nov 11, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 3d45e5b, target branch master) failed with status FAILURE.

@msakai
Copy link
Contributor Author

msakai commented Nov 11, 2019

(but the line is over 79 char..?)

Oops, Sorry. I didn't noticed that because I made the PR on browser 😅.
Shall I add a commit to fold the line?

@take-cheeze
Copy link
Member

Hmm strange.
Seems CI isn't checking onnx-chainer code:

chainer/scripts/ci/travis/steps.sh

Lines 118 to 126 in b35ce74

check_targets=(
"$REPO_DIR"/*.py
"$REPO_DIR"/chainer
"$REPO_DIR"/chainermn
"$REPO_DIR"/chainerx
"$REPO_DIR"/tests
"$REPO_DIR"/examples
"$REPO_DIR"/chainerx_cc/examples
)

@take-cheeze
Copy link
Member

Should be checked with: #8400

@take-cheeze take-cheeze removed the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 11, 2019
@take-cheeze
Copy link
Member

Checked the code under onnx_chainer/ with CI and now correctly found:
https://travis-ci.org/chainer/chainer/jobs/609149881#L391
Sorry to bother but could you fix it and make travis green?

@msakai
Copy link
Contributor Author

msakai commented Nov 12, 2019

Sure!

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 12, 2019
@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e1a66b6, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e1a66b6, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e1a66b6, target branch master) succeeded!

@mergify mergify bot merged commit cbf26e3 into chainer:master Nov 14, 2019
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
@kmaehashi kmaehashi added the cat:bug Bug report or fix. label Dec 5, 2019
@emcastillo emcastillo changed the title Fix AttributeError in WrappedFunctionNode.forward Fix AttributeError in WrappedFunctionNode.forward Dec 5, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit e1a66b6, target branch master) succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@take-cheeze take-cheeze take-cheeze approved these changes

@disktnk disktnk disktnk approved these changes

Assignees

@take-cheeze take-cheeze

Labels
cat:bug Bug report or fix. ONNX Related to ONNX st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@msakai @take-cheeze @chainer-ci @disktnk @kmaehashi @toslunar